Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to std::process::Command #271

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix broken link to std::process::Command #271

merged 1 commit into from
Oct 15, 2020

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Oct 15, 2020 •
edited
Loading

Intra-doc links do not yet work in markdown files; see rust-lang/rust#77974.

Part of rust-lang/rust#77971.

@jyn514
Fix broken link to std::process::Command
70de9a2 
Intra-doc links do not yet work in markdown files; see
rust-lang/rust#77974.
@jyn514 jyn514 requested a review from a team as a code owner October 15, 2020 14:00
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Oct 15, 2020
@jyn514
Copy link
Contributor Author

jyn514 commented Oct 15, 2020

You can see the currently broken link at https://docs.rust-embedded.org/book/interoperability/c-with-rust.html#triggering-external-build-systems.

@jyn514 jyn514 mentioned this pull request Oct 15, 2020
Merged
therealprof
therealprof approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 15, 2020

Build succeeded:

@bors bors bot merged commit ca8169e into rust-embedded:master Oct 15, 2020
@jyn514 jyn514 deleted the broken-links branch October 15, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @rust-highfive @therealprof @adamgreig